NoDAG prototyping #1011
Draft
NoDAG prototyping #1011
+1,250
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolag
reviewed
Jan 27, 2025
|
|
||
| func RunWorkflow(runtime sdk.RuntimeV2, triggerOutputs basictrigger.TriggerOutputs) error { | ||
| // two action calls "futures" | ||
| actionCall1, _ := wasm.NewCapabilityCall[basicaction.ActionInputs, basicaction.ActionConfig, basicaction.ActionOutputs]( |
There was a problem hiding this comment.
Two things. First, the runtime should make the call, or you can't test without WASM. Second, we'll have generated helpers for the calls that take and return the right types given a runtime :).
pkg/workflows/wasm/runner_v2.go
Outdated
Comment on lines
53
to
98
| switch { | ||
| case req.GetSpecRequest() != nil: | ||
| rsp, innerErr := r.handleSpecRequest(factory, req.Id) | ||
| if innerErr != nil { | ||
| resp.ErrMsg = innerErr.Error() | ||
| } else { | ||
| resp = rsp | ||
| } | ||
| case req.GetRunRequest() != nil: | ||
| rsp, innerErr := r.handleRunRequest(factory, req.Id, req.GetRunRequest()) | ||
| if innerErr != nil { | ||
| resp.ErrMsg = innerErr.Error() | ||
| } else { | ||
| resp = rsp // should happen only when workflow is done processing (i.e. no more capability calls) | ||
| } | ||
| default: | ||
| resp.ErrMsg = "invalid request: message must be SpecRequest or RunRequest" | ||
| } |
There was a problem hiding this comment.
For regular execution, I don't think the WASM should asked to do work. How would I enable parallelism?
There was a problem hiding this comment.
I don't quite follow but I think the planned change to use a separate import will resolve this concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.